Skip to content

FI-19 bumped gl-plot3d to benefit from fix in gl-axes3d #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2016
Merged

FI-19 bumped gl-plot3d to benefit from fix in gl-axes3d #982

merged 1 commit into from
Sep 27, 2016

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Sep 27, 2016

Applies the fix for the font change detection bug FI-19.

It needs that these are merged and npm published first:

  1. Tick diffing to check all properties that impact the rendered result gl-vis/gl-axes3d#8
  2. Bumped versions to benefit from a gl-axes3d fix gl-vis/gl-plot3d#5

@etpinard
Copy link
Contributor

gifrecord_2016-09-27_100600

Fixed. Thanks!

@etpinard etpinard added bug something broken status: reviewable labels Sep 27, 2016
@etpinard etpinard added this to the v1.18.0 milestone Sep 27, 2016
@etpinard
Copy link
Contributor

@monfera great PR. Thanks 🎉

@etpinard etpinard merged commit 708e0ff into plotly:master Sep 27, 2016
@monfera monfera deleted the FI-19 branch September 27, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@monfera @etpinard